Skip to content

Add ARM template to Getting Started assets #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 26, 2025
Merged

Add ARM template to Getting Started assets #36

merged 3 commits into from
Mar 26, 2025

Conversation

russd2357
Copy link
Collaborator

Purpose

Add an ARM template to the Getting Started assets to help users deploy the solution to Azure.

  • ...

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[X] Other... Please describe:  Add and ARM template to the Getting Started assets to enable using the --template-uri option for az deployment

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

pauldotyu
pauldotyu requested changes Mar 25, 2025
View reviewed changes
Copy link
Collaborator

@pauldotyu pauldotyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Bicep, can you rename the Microsoft.ManagedIdentity/userAssignedIdentities resource to be more generic like myidentityxxxxxxxx and re-gen this ARM template? This way we can use the single managed identity for other resources. Currently, it is named mykeyvaultxxxx-identity and might cause confusion if we use it for say accessing a CosmosDB.

@pauldotyu pauldotyu merged commit febee81 into main Mar 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldotyu pauldotyu pauldotyu requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@russd2357 @pauldotyu